Open
Conversation
Signed-off-by: ssannkkallpp <ssannkkallpp@gmail.com>
e0bda7a to
49add4e
Compare
| // SetupTestRepo creates a temporary git repository with two commits: an initial commit | ||
| // and a second commit containing a gittuf metadata envelope at metadata/root.json, | ||
| // with refs/gittuf/policy pointing at that second commit. | ||
| func SetupTestRepo(t *testing.T) (string, string, func()) { |
Collaborator
There was a problem hiding this comment.
I suggest using gittuf's testing helpers to create a repository here, e.g. copy/use https://github.com/gittuf/gittuf/blob/main/internal/policy/helpers_test.go.
Verification of gittuf repos is likely on the roadmap for the visualizer so having the test methods ready to plug in to that would be good.
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestCloneAndFetchRepo_Success(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
I suggest bundling the tests into a parent test with child t.Runs, e.g. TestCloneAndFetchRepo with t.Run for each individual case. See https://github.com/gittuf/gittuf/blob/main/internal/policy/policy_test.go#L25 for an example.
| backend/venv/ | ||
|
|
||
| # Go test artifacts | ||
| go-backend/tests/TEST_DESCRIPTIONS.md |
Collaborator
There was a problem hiding this comment.
Is this a listing/description file that you intended to add?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a comprehensive unit test suite for the Go backend. Tests cover the handlers, services, and validation layers using temporary in-memory git repositories.
Running the Tests
From the go-backend/ directory:
Test Structure