fix(forge/github): sanitize gql query docs based on gated feature compatibility - #3178
Open
setchy wants to merge 4 commits into
Open
fix(forge/github): sanitize gql query docs based on gated feature compatibility#3178setchy wants to merge 4 commits into
setchy wants to merge 4 commits into
Conversation
…patibility Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
marked this pull request as draft
August 13, 2026 13:41
setchy
marked this pull request as ready for review
August 13, 2026 13:41
…ctive-with-sanitizing
…patibility Signed-off-by: Adam Setch <adam.setch@outlook.com>
github-actions
Bot
added
bug
|
Member
Author
|
@sphinxrave - if you have a moment, we would appreciate if you could test the build from this branch. Should resolve the GHE stacked issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3174 (attempt two 😅)
GHES doesn't expose PullRequest.stackEntry (or Discussion.isAnswered before 3.12).
The old
@include(if:)guard didn't help, since GraphQL Servers will validate the query document field names regardless of client-side directives, and rejected the unused variable, breaking PR enrichment for all GHE users.This adds a custom
@gated(requires: "...")directive, marks the two fields with it, and strips unsupported fields (plus the directive) from the query before sending via stripGatedSelections().@include/@skiponly affect execution, so physically removing the selection is the only reliable fix; the directive keeps it declarative in the sources and codegen still types the fields.