Repository navigation
Stack adjacent decisions in a document as a shuffleable deck - #480
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deck slot z-indexes outranked the selection bubble, so isolate the stage. A modal sheet leaves live-region ancestors un-inerted, so the sidecar helper now checks that everything else in the editor is inert. Spacing specs use settled cards, since adjacent open cards now stack into a deck. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A deck now stays on the run's first node while that card is hidden, so a member leaving no longer remounts it and drops order, focus and drafts. When the last open card is answered, focus moves to its settled line. The count reads a card's place in the resting stack, so the top card is 1 of N. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…onent The build minifies 600ms to .6s, so the deck read its linger and shuffle durations as under a millisecond and never animated. Parse the unit. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- Drop the unused Deck className prop so the deck's class is a literal.
- Make each deck a named group ("N decisions") instead of a region
landmark that duplicated the Decisions tab name.
- Mark the deck as touched only by keys it handles, pointer presses and
clicks, so typing inside a card does not claim a collaborator's settle.
- Remove the dead reduced-motion block; the deck declares no transitions.
- Cover a collaborator answering the reader's current top card.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scripts/design-contract/exceptions/dynamic-editor.json: - packages/editor/src/widgets/questionnaire.tsx (pointing props on Undecided/Decided <QuestionView>, and presence.className on QuestionnaireCard's collapse <div>): reviewed against origin/main. The three dynamic expressions are textually unchanged. The branch splits InlineQuestionnaire into a deck chooser and InlineCard, which still feeds QuestionnaireCard the same places/relations from the questions store and the same shared presence state. Deck items carry only an id, a settled flag, a header string and the card node, so no caller class, style, typography or paint value reaches these boundaries. Cases and contexts are unchanged; only the source hash is renewed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On phones each open card is already a chip that opens the Decisions pane, so a run of adjacent decisions renders its chips in place rather than stacking them in a deck. Also mark the browser-realm callback in the sidecar spec as deliberately scoped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The inline deck wraps the card without passing classes, typography or paint into the pointing props or the collapse presence classes; only questionnaire.tsx's source hash changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
When decision cards sit next to each other in a document, with only empty lines between them, they now render as a deck instead of a column:
The deck is presentation only. Questionnaire nodes and records are unchanged, and the deck is hosted by the run's first node, so it stays mounted while members change.
Phones: where decision cards already become chips that open the Decisions pane, the chips render as before and no deck is built.
Slice 3 of the nested-documents work. Slice 4, the Decisions tab as a deck, builds on this.
Screenshots
Deck at rest
Mid-shuffle
Decisions tab "Show in document" brings a back card forward
Phone: chips, no deck
Accessibility
groupwitharia-roledescription="carousel", named "N decisions", so there is no duplicate "Decisions" landmark.inertandaria-hidden.Testing
e2e/inline-decision-deck.e2e.tscovers:--duration-lingeras.6s, which was parsed as 0.6 ms, so the deck never animated.sidecar.e2e.ts:editorIsModalBackgroundnow accepts a modal that hides the editor's children rather than the editor root, because the deck's live region stays exposed. Nothing is hidden less.sidecar-document-spacing.e2e.ts: now seeds answered cards, because adjacent open cards form a deck by design.bun run types, unit tests, oxlint and the design-contract check pass. Thee2especs for the deck, sidecar and phone decisions pass on the rebased head (72 tests).Design-contract review
Renewed after a data-flow review, with the maintainer's approval:
questionnaire.tsx: the dynamic owner moved intoInlineCard, but the expressions are unchanged.deck.tsx: uses a literal class.🤖 Generated with Claude Code