Repository navigation
fix(desktop): recognize complete native patch prefixes - #137
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a native patch to an already patched Peekaboo checkout could fail because a later patch changed the context needed to recognize an earlier one. This blocked the image-read and application-launch builds in #135 and #136.
The build now compares the checkout against complete ordered patch prefixes in a private Git index, applies only the missing suffix, and verifies the full result. Unexpected tracked or untracked changes still refuse before mutation; the real dependency index remains untouched. New patches append to the stack, with the independent close patch ordered after clipboard text so existing builds remain valid prefixes.
Related to #8. Validation passed using the actual helper block against six real pinned Git checkouts: pristine, previous text prefix, full stack, the previously landed close-before-text order, tracked drift, and untracked source drift. All successful cases reached the same expected source tree; full/drift cases and every real index stayed unchanged.
bun types,bun run ci, andgit diff --checkpass. This changes build preparation only; no new native input or app launch was needed.Built in Ace
Used Codex terminal and file tools to reproduce the build failure, implement and review the correction, and validate real dependency checkouts under Nate’s explicit temporary exception to Ace-only development for #8. Ace’s normal signed build path exposed this blocker while developing native computer-use capabilities. The ongoing dogfooding gap is tracked in #5 and #8.