fix: log progress tracker refresh errors instead of silently swallowing - #3975
Open
Quratulain-bilal wants to merge 2 commits into
Open
fix: log progress tracker refresh errors instead of silently swallowing#3975Quratulain-bilal wants to merge 2 commits into
Quratulain-bilal wants to merge 2 commits into
Conversation
The bare 'except Exception: pass' in StepTracker._maybe_refresh() completely hid rendering bugs in the Rich progress display. Now logs at DEBUG level with full traceback for diagnostics.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds DEBUG-level traceback logging for suppressed progress refresh failures.
Changes:
- Introduces a module logger.
- Logs refresh callback exceptions with traceback details.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/_console.py |
Logs StepTracker refresh failures for diagnostics. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
- Test that _maybe_refresh logs exceptions instead of silently swallowing - Verify diagnostic message and traceback are recorded in DEBUG logs - Confirm tracker update completes normally despite refresh callback failure Requested by Copilot in PR github#3975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bare except Exception: pass in StepTracker._maybe_refresh() completely hid rendering bugs in the Rich progress display.
Fix
Now logs at DEBUG level with full traceback for diagnostics.