fix: handle TimeoutExpired and OSError in dispatch_command() - #3921
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix: handle TimeoutExpired and OSError in dispatch_command()#3921Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
subprocess.run() with timeout parameter can raise TimeoutExpired if the timeout elapses. Also catch OSError for cases where the binary is not found or not executable (TOCTOU race between shutil.which and run).
Contributor
There was a problem hiding this comment.
Pull request overview
Adds structured handling for command timeouts and execution failures during captured CLI dispatch.
Changes:
- Maps timeouts to exit code 124.
- Converts
OSErrorfailures into dispatch results.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/base.py |
Handles captured dispatch exceptions. |
src/specify_cli/integrations/copilot/__init__.py |
Adds equivalent Copilot handling. |
Review details
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
| "stdout": "", | ||
| "stderr": f"Command timed out after {timeout}s", | ||
| } | ||
| except OSError as exc: |
| "stdout": "", | ||
| "stderr": f"Command timed out after {timeout}s", | ||
| } | ||
| except OSError as exc: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
subprocess.run()with timeout parameter can raiseTimeoutExpiredif the timeout elapses. Also catchOSErrorfor cases where the binary is not found or not executable.Fix
Added try/except blocks to handle both exception types in both base and copilot dispatch_command().