fix(workflows): make security requirements sync deterministic - #3832
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot review |
Contributor
There was a problem hiding this comment.
Pull request overview
Makes security requirement synchronization deterministic while preserving scheduled live upgrades.
Changes:
- Diffs PR heads from their merge base.
- Seeds compilation from committed pins and removes
--upgrade. - Updates workflow tests for refs, pins, and flags.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/security.yml |
Uses the actual PR head SHA. |
.github/scripts/check_security_requirements.py |
Adds merge-base diffing and deterministic compilation. |
tests/test_security_workflow.py |
Verifies the revised synchronization behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3802
PR checks now diff the actual head from its merge base, seed the temporary output from the committed snapshot, and compile without
--upgrade. Scheduled audits keep their existing live upgrade check.Tests cover the workflow refs, merge-base diff, seeded pins, and compile flags.