fix: bound fallback response read in preset download - #3777
Open
Quratulain-bilal wants to merge 3 commits into
Open
fix: bound fallback response read in preset download#3777Quratulain-bilal wants to merge 3 commits into
Quratulain-bilal wants to merge 3 commits into
Conversation
Replace unbounded response.read() fallback in presets/_commands.py with read_response_limited() to prevent DoS via oversized preset archive downloads.
Contributor
There was a problem hiding this comment.
Pull request overview
Attempts to bound preset archive downloads using the shared response-size limiter.
Changes:
- Imports the shared 50 MiB download limit and reader.
- Applies the limiter in the
TypeErrorfallback path.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/presets/_commands.py |
Adds bounded fallback response reading. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace unbounded
esponse.read()\ fallback in \presets/_commands.py\ with
ead_response_limited()\ to prevent DoS via oversized preset archive downloads.
Changes
ead_response_limited\ to the existing _download_security\ import