Skip to content

fix(templates): point constitution sync checklist at installed command files#3418

Open
marcelsafin wants to merge 6 commits into
github:mainfrom
marcelsafin:fix/660-constitution-commands-path
Open

fix(templates): point constitution sync checklist at installed command files#3418
marcelsafin wants to merge 6 commits into
github:mainfrom
marcelsafin:fix/660-constitution-commands-path

Conversation

@marcelsafin

Copy link
Copy Markdown
Contributor

Fixes #660

Root cause

Step 4 of the constitution command's consistency-propagation checklist tells the agent to:

Read each command file in .specify/templates/commands/*.md (including this one) …

specify init never creates .specify/templates/commands/ — command templates are rendered directly into the agent-specific directory (.github/prompts/, .claude/commands/, .codex/commands/, …). See also the assessment on #3086: keeping commands out of .specify/templates/ is intentional, so the fix is to correct the reference, not to start copying files there.

The result today: this checklist step points at a path that does not exist in any initialized project, so the outdated-reference sweep it describes can never actually run.

Change

One line — the step now reads the installed speckit.* command files for the active agent (with .github/prompts/ and .claude/commands/ as examples), instead of the nonexistent template path.

Testing

No tests pin this template's prose. Verified the new strings are untouched by CommandRegistrar.rewrite_project_relative_paths (only bare scripts/, templates/, memory/ prefixes are rewritten).

…d files

The consistency-propagation checklist told the agent to read
.specify/templates/commands/*.md, but specify init never creates that
directory — command templates are rendered straight into the
agent-specific directory (.github/prompts/, .claude/commands/, ...).
The checklist step could therefore never run against real files.

Point it at the installed speckit.* command files for the active agent
instead.

Fixes github#660

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@marcelsafin marcelsafin requested a review from mnriem as a code owner July 8, 2026 23:01
Copilot AI review requested due to automatic review settings July 8, 2026 23:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an incorrect reference in the Constitution command template so the “consistency propagation checklist” points to command files that actually exist in initialized projects (agent-installed commands/skills), rather than a non-existent .specify/templates/commands/ directory.

Changes:

  • Update the checklist to reference installed command files for the active agent instead of .specify/templates/commands/*.md.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread templates/commands/constitution.md Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 8, 2026 23:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread templates/commands/constitution.md Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 8, 2026 23:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread templates/commands/constitution.md Outdated
Copilot skills mode installs speckit-<name>/SKILL.md under .github/skills/,
not .github/agents/. Mention both directories and the SKILL.md layout.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 8, 2026 23:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread templates/commands/constitution.md Outdated
The previous commit dropped the speckit-* flat-file variant used by
Cline and others while adding the SKILL.md layout. Name all three:
speckit.*, speckit-*, and speckit-<name>/SKILL.md.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 9, 2026 00:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Low

Comment thread templates/commands/constitution.md Outdated

@mnriem mnriem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Copilot feedback

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 10, 2026 18:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@marcelsafin

marcelsafin commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Copilot re-reviewed 180d33a and raised no new comments. The requested feedback is addressed and this is ready for another maintainer pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Constitution command references a path that doesn't exist

3 participants