fix(ui): advertise get_me as an app via _meta.ui.visibility#2503
Merged
Conversation
The get_me tool wires a UI resource via _meta.ui.resourceUri but was missing the visibility array. MCP clients that key off visibility to decide whether to render a tool as an app (e.g. VS Code's MCP Apps renderer) silently skipped get_me as a result. Add visibility: ["model", "app"] to match the other UI-enabled tools (issue_write, create_pull_request). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes MCP client UI rendering for the get_me tool by adding the missing _meta.ui.visibility field so clients that rely on visibility can surface the associated UI resource as an app.
Changes:
- Add
_meta.ui.visibility: ["model", "app"]toget_me’s tool metadata inpkg/github/context_tools.go. - Regenerate the
get_metool schema snapshot to reflect the updated_meta.uiblock.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/context_tools.go | Adds the visibility array to get_me’s _meta.ui metadata alongside resourceUri. |
| pkg/github/toolsnaps/get_me.snap | Updates the toolsnap JSON to include _meta.ui.visibility for get_me. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The
get_metool wires an MCP App UI resource (ui://github-mcp-server/get-me) via_meta.ui.resourceUri, but the_meta.uimap was missing thevisibilityarray. MCP clients that key offvisibilityto decide whether to render the resource as an app (e.g. VS Code's MCP Apps renderer) silently skipget_meas a result.Fix
Add
visibility: ["model", "app"]toget_me's_meta.ui, matching the existing UI-enabled tools (issue_write,create_pull_request).Changes
pkg/github/context_tools.go— one-line addition to the_meta.uimap literal inGetMe.pkg/github/__toolsnaps__/get_me.snap— regenerated viaUPDATE_TOOLSNAPS=true go test ./pkg/github -run 'Test_GetMe$'.script/lintandscript/testboth pass.