Skip to content

Conversation

@pelikhan
Copy link
Contributor

@pelikhan pelikhan commented Aug 4, 2025

If gh-models is not found for some reason, hard fail the integration tests.

Also run check to avoid wasting tokens if some unit tests are not panning.

@pelikhan pelikhan requested a review from a team as a code owner August 4, 2025 10:48
Copilot AI review requested due to automatic review settings August 4, 2025 10:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the integration test reliability by making tests fail fast when the binary is missing and ensuring code quality checks pass before expensive API calls. The changes focus on preventing wasted resources and providing clearer failure feedback.

  • Changes binary name from test-specific to production binary name
  • Converts binary missing condition from skip to fatal error for faster feedback
  • Updates test prompts from "pain" to "bread" while maintaining French translation validation
  • Adds check prerequisite to integration target to validate code quality first

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
integration/integration_test.go Updates binary name, changes missing binary to fatal error, and modifies test prompts
Makefile Adds check dependency to integration target to run quality checks before tests
Comments suppressed due to low confidence (2)

integration/integration_test.go:92

  • The assertion is checking for 'pain' but the test prompt was changed to ask for 'bread' in French. This should check for 'pain' (French for bread) instead.
	require.Contains(t, strings.ToLower(stdout), "pain")

integration/integration_test.go:100

  • The assertion is checking for 'pain' but the test prompt was changed to ask for 'bread' in French. This should check for 'pain' (French for bread) instead.
	require.Contains(t, strings.ToLower(stdout), "pain")

@pelikhan pelikhan requested a review from sgoedecke August 4, 2025 10:50
@sgoedecke sgoedecke merged commit f38cd97 into main Aug 4, 2025
5 checks passed
@sgoedecke sgoedecke deleted the integation-fix branch August 4, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants