Skip to content

fix(workflow): restrict pr-code-quality-reviewer to COMMENT/REQUEST_CHANGES reviews - #48663

Merged
pelikhan merged 1 commit into
mainfrom
copilot/update-pr-quality-agentic-workflow
Jul 28, 2026
Merged

fix(workflow): restrict pr-code-quality-reviewer to COMMENT/REQUEST_CHANGES reviews#48663
pelikhan merged 1 commit into
mainfrom
copilot/update-pr-quality-agentic-workflow

Conversation

Copilot AI commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

GITHUB_TOKEN cannot approve pull requests — without allowed-events, the agent would attempt APPROVE on clean PRs and fail at the GitHub API level.

Changes

  • Frontmatter — adds allowed-events: [COMMENT, REQUEST_CHANGES] to submit-pull-request-review, enforcing the constraint at the safe-outputs layer before it reaches GitHub
  • Step 5 prompt — replaces APPROVE instruction with COMMENT for the no-blocking-issues path; removes the contradictory trailing sentence
  • Lock file — recompiled to propagate allowed_events into the runtime handler config

Run: https://github.com/github/gh-aw/actions/runs/30375513874

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 10.1 AIC · ⌖ 6.1 AIC · ⊞ 7.2K ·
Comment /souschef to run again

…review in pr-code-quality-reviewer

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title feat(workflow): enforce COMMENT/REQUEST_CHANGES-only reviews in pr-code-quality-reviewer fix(workflow): restrict pr-code-quality-reviewer to COMMENT/REQUEST_CHANGES reviews Jul 28, 2026
Copilot AI requested a review from pelikhan July 28, 2026 15:26
@pelikhan
pelikhan marked this pull request as ready for review July 28, 2026 15:38
Copilot AI review requested due to automatic review settings July 28, 2026 15:38
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. PR #48663 contains only workflow configuration changes (.md and .lock.yml files). Test Quality Sentinel skipped.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #48663 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restricts the reviewer workflow to review events supported by GITHUB_TOKEN.

Changes:

  • Allows only COMMENT and REQUEST_CHANGES.
  • Replaces APPROVE prompt guidance with COMMENT.
  • Recompiles the generated workflow configuration.
Show a summary per file
File Description
.github/workflows/pr-code-quality-reviewer.md Updates review constraints and instructions.
.github/workflows/pr-code-quality-reviewer.lock.yml Propagates allowed events into runtime configuration.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Medium

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Config change verified

Small, correct, self-consistent change: adds allowed-events: [COMMENT, REQUEST_CHANGES] to submit-pull-request-review and updates the prompt to drop the now-disallowed APPROVE path. Lock file JSON (allowed_events) matches the frontmatter change exactly. No correctness, security, or maintainability issues found in the diff.

🔎 Code quality review by PR Code Quality Reviewer · sonnet50 · 8.67 AIC · ⌖ 4.21 AIC · ⊞ 7.4K
Comment /review to run again

@github-actions github-actions Bot mentioned this pull request Jul 28, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are correct and consistent. The allowed-events: [COMMENT, REQUEST_CHANGES] constraint is properly propagated from frontmatter through to both the config.json and GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG in the lock file. The prompt update removes the APPROVE path cleanly with no contradictions remaining.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 10 AIC · ⌖ 4.53 AIC · ⊞ 5K

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review

Applied /diagnosing-bugs — correct, minimal fix for a well-understood root cause. No blocking issues found.

Positive highlights:

  • Fix applied at safe-outputs layer so even a misbehaving LLM cannot bypass the constraint
  • Both config.json heredoc and GH_AW_SAFE_OUTPUTS_HANDLER_CONFIG env var updated in sync
  • Prompt changes minimal and focused; lock file properly recompiled

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 14.8 AIC · ⌖ 5.18 AIC · ⊞ 6.7K
Comment /matt to run again

@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot run pr-finisher skill

@pelikhan
pelikhan merged commit 0a06139 into main Jul 28, 2026
45 of 48 checks passed
@pelikhan
pelikhan deleted the copilot/update-pr-quality-agentic-workflow branch July 28, 2026 16:09
Copilot stopped work on behalf of pelikhan due to an error July 28, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants