Closed
feat: add fast stale-lock-file CI gate for workflow markdown edits#48563
Conversation
Add a fast, binary-free `check-stale-lock-files` CI job that catches stale workflow lockfiles early, before the heavier `check-workflow-drift` job requires a full binary build. Changes: - ci.yml: add standalone `check-stale-lock-files` job using fetch-depth: 0 and GITHUB_BEFORE_SHA env var (from github.event.before) for push events - Makefile: extend check-stale-lock-files target to also check GITHUB_BEFORE_SHA (checked after CHECK_STALE_LOCK_BASE_REF and GITHUB_BASE_REF), with updated doc comment listing all supported env vars Closes #48154 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enforce make recompile after workflow markdown edits
feat: add fast stale-lock-file CI gate for workflow markdown edits
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale
.lock.ymlfiles after editing.github/workflows/*.mdare the highest-confidence recurring CI failure. The existingcheck-workflow-driftjob catches this but only after building the binary (~10 min). This adds a binary-free fast gate that fails in ~30 seconds.Changes
ci.yml— newcheck-stale-lock-filesjobfetch-depth: 0and passesgithub.event.beforeasGITHUB_BEFORE_SHAto diff exactly what changed in the pushMakefile— extendcheck-stale-lock-filestargetGITHUB_BEFORE_SHA(checked afterCHECK_STALE_LOCK_BASE_REFandGITHUB_BASE_REF), enabling the Makefile target to resolve the correct base ref for push events whereGITHUB_BASE_REFis unsetmake recompileafter workflow markdown edits #48154