Skip squid log cleanup when squid never started

[Copilot]

Cleanup assumed the squid log path existed whenever proxyLogsDir was configured. In runs where squid never launched, cleanup still tried to chmod that path, creating avoidable noise/failure in post-run cleanup.

• Cleanup guard

  • Tighten runtime log preservation so chmod only runs when the target directory actually exists.
  • This keeps cleanup tolerant of partial startup paths where squid logs were never created.

• Regression coverage

  • Add a focused cleanup test for the missing proxyLogsDir case.
  • Preserve existing behavior for real squid log directories and external proxy log paths.

• Behavioral shape

  const targetDir = runtimeSubdir ? path.join(runtimeDir, runtimeSubdir) : runtimeDir;
  if (fs.existsSync(targetDir)) {
    execa.sync('chmod', ['-R', 'a+rX', targetDir]);
  }

This keeps artifact preservation behavior unchanged for present logs while making cleanup a no-op for absent squid log directories.

• Fixes squid logs cleanup fails when squid wasn't launched #6426

[Copilot]

Pull request overview

Prevents cleanup errors when Squid never created its configured log directory.

Changes:

• Guard log permission repair with an existence check.
• Add regression coverage for missing Squid logs.

Show a summary per file

File	Description
src/artifact-preservation.ts	Skips chmod for absent runtime artifact directories.
src/docker-manager-cleanup.test.ts	Tests cleanup with a missing proxyLogsDir.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Medium

[github-actions]

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

[github-actions]

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

[github-actions]

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

[github-actions]

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

[github-actions]

✅ Contribution Check completed successfully!

PR follows CONTRIBUTING.md; no comment needed.

[github-actions]

✅ Build Test Suite completed successfully!

[github-actions]

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

[github-actions]

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

[github-actions]

✅ Smoke Gemini completed. All facets verified. 💎

[github-actions]

🔌 Smoke Services — All services reachable! ✅

[github-actions]

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

[github-actions]

📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤

[github-actions]

✅ Smoke Claude passed

[github-actions]

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

[github-actions]

🚀 Security Guard has started processing this pull request

[github-actions]

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

[github-actions]

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	98.45%	98.49%	📈 +0.04%
Statements	98.29%	98.32%	📈 +0.03%
Functions	99.16%	99.16%	➡️ +0.00%
Branches	94.30%	94.29%	➡️ -0.01%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
src/log-directory-setup.ts	96.2% → 100.0% (+3.78%)	96.3% → 100.0% (+3.71%)

---

Coverage comparison generated by scripts/ci/compare-coverage.ts

[github-actions]

Smoke test: Copilot network isolation egress

EGRESS_RESULT allow=pass deny=pass

✅ Test 1 (allowed domain): api.github.com → HTTP 200
✅ Test 2 (blocked domain): example.com → blocked (403 from proxy)

Overall: PASS — @lpcox

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

[github-actions]

Smoke Test: Claude Engine Validation

Check	Result
API Status	✅ PASS
GH Check	✅ PASS
File Status	✅ PASS

Overall Result: PASS ✅

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Smoke Claude for #6427 · 56.1 AIC · ⊞ 5.9K · ◷
_{Add label ready-for-aw to run again}

[github-actions]

Smoke Test: BYOK Mode ✅

• ✅ MCP connectivity (GitHub API)
• ✅ GitHub.com HTTP 200
• ✅ File write/read
• ✅ BYOK inference via api-proxy sidecar

Status: PASS | Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) → api-proxy → api.githubcopilot.com

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

[github-actions]

Smoke Test: Copilot PAT Auth

Test	Result
GitHub MCP connectivity	✅ (PR context resolved)
GitHub.com HTTP	⚠️ pre-step data unavailable (template vars unresolved)
File write/read	⚠️ pre-step data unavailable (template vars unresolved)

Overall: PARTIAL — PR context valid; pre-computed step outputs were not injected.

Auth mode: PAT (COPILOT_GITHUB_TOKEN) | Author: @lpcox

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔑 PAT report filed by Smoke Copilot PAT
_{Add label ready-for-aw to run again}

[github-actions]

🔬 Smoke Test Results

Test	Status
GitHub MCP Connectivity	✅
GitHub.com HTTP	✅
File Write/Read	✅

Overall: PASS

cc @lpcox

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

[github-actions]

Smoke Test: API Proxy OpenTelemetry Tracing

Scenario	Result	Notes
S1: Module Loading	✅ Pass	otel.js loads successfully; exports: startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled + internal helpers
S2: Test Suite	✅ Pass	59/59 tests passed across otel.test.js and otel-fanout.test.js
S3: Env Var Forwarding	✅ Pass	src/services/api-proxy-env-config.ts forwards GH_AW_OTLP_ENDPOINTS, OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS, GITHUB_AW_OTEL_TRACE_ID, GITHUB_AW_OTEL_PARENT_SPAN_ID, OTEL_SERVICE_NAME
S4: Token Tracker Integration	✅ Pass	onUsage callback exists in token-tracker-http.js (line 285, invoked at line 343) as the OTEL hook point
S5: OTEL Diagnostics	✅ Pass	Module activates; falls back to /var/log/api-proxy/otel.jsonl when no OTLP endpoint configured

All 5 scenarios pass. OTEL tracing integration is fully functional.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

[github-actions]

Smoke Test: Services Connectivity

• Redis PING: ❌ (host.docker.internal DNS resolution failed; 127.0.0.1 connection refused)
• PostgreSQL pg_isready: ❌ (no response on either address)
• PostgreSQL SELECT 1: ❌ (connection refused)

Overall: FAIL — service containers are not reachable from this runner environment.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

[github-actions]

Merged PRs: [docs] Document ANTHROPIC_AUTH_TOKEN protection in API proxy isolation; chore: upgrade gh-aw to v0.82.13 (pre-release) and recompile workflows
GitHub MCP: ✅
safeinputs-gh: ✅
Playwright: ✅
File write: ✅
Discussion comment: ✅
Build: ✅
Overall: PASS

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

• awmgmcpg
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

[github-actions]

Chroot Version Comparison ✅

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.13	✅ YES
Node.js	v24.18.0	v24.18.0	✅ YES
Go	go1.22.12	go1.22.12	✅ YES

All runtimes match between host and chroot environment.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

[github-actions]

Smoke Test: Gemini Engine Validation

• GitHub MCP Testing: ❌ (Access denied by integrity policy)
• GitHub.com Connectivity: ❌ (Network unreachable - 000)
• File Writing Testing: ✅
• Bash Tool Testing: ✅

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini
_{Add label ready-for-aw to run again}

[github-actions]

@lpcox Smoke test: MCP ✅; GitHub.com ✅; File I/O ❌; BYOK inference ✅. Running in direct BYOK mode via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) via Entra. Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
_{Add label ready-for-aw to run again}

[github-actions]

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	passed	✅ PASS
Go	env	✅	passed	✅ PASS
Go	uuid	✅	passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Build Test Suite for #6427 · 36.4 AIC · ⊞ 7.1K · ◷
_{Add label ready-for-aw to run again}

[github-actions]

🔥 Smoke Test: Docker Sbx Validation

Test	Result
GitHub MCP Connectivity	✅ MCP server responded
GitHub.com HTTP	⚠️ Pre-step data not interpolated
File Write/Read	⚠️ Pre-step data not interpolated

Overall: ⚠️ PARTIAL — MCP connectivity confirmed; pre-computed step outputs were not interpolated into the prompt template.

cc @lpcox

📰 BREAKING: Report filed by Smoke Docker Sbx
_{Add label ready-for-aw to run again}

[github-actions]

@lpcox

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

• GitHub MCP Testing: ✅ (pre-fetched data validated)
• GitHub.com connectivity: ✅
• File write/read test: ✅
• BYOK inference test: ✅

Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)
_{Add label ready-for-aw to run again}