C# 14: Null conditional assignment.#21118
Closed
michaelnebel wants to merge 4 commits into
Closed
Conversation
Contributor
Author
|
Closed in favor of #21158 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add tests for null conditional assignments. The null conditional assignments are supported out of the box by the extractor.
As far as I can tell, we don't need to make any modifications to the guards library, the dereference logic or the nullness logic. However, it appears that conditional access has been overlooked in the
MaybeNullExprclass in theNullnessmodule. This has been fixed.