Skip to content

docs(skills): update git-commit and narrow commit-message-storyteller 🤖🤖🤖 - #4869

Open
burakkaygusuz wants to merge 3 commits into
github:mainfrom
burakkaygusuz:docs/commit-skills
Open

burakkaygusuz wants to merge 3 commits into
github:mainfrom
burakkaygusuz:docs/commit-skills

Conversation

@burakkaygusuz

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

Updates the git-commit skill and narrows the commit-message-storyteller skill so that the two skills do not overlap. The earlier version told the agent to run commands that fail or that wait for input. The update follows the Agent Skills specification, Conventional Commits 1.0.0, and Git 2.56.

Changelog

git-commit fixes

  • Remove git add -p. The agent cannot answer the interactive prompts.
  • Quote glob pathspecs (git add -- '*.test.*'). Without quotes, the shell expands the glob and does not find the files in subdirectories.
  • Replace the $(cat <<'EOF' ...) heredoc with repeated -m options. The heredoc does not work in PowerShell.
  • Fix the header template from <type>[scope]: to <type>(<scope>):.
  • Limit allowed-tools from Bash to shell(git:*), the Copilot pattern for Git commands.

git-commit updates

  • Rewrite the description with user intent triggers and exclusions. Exclude requests for only a commit message, so that the skill does not overlap with commit-message-storyteller.
  • Add the compatibility field.
  • Read the repository commit rules (commitlint, CONTRIBUTING.md, git log) first. State that Conventional Commits defines only feat and fix.
  • Add git add --resolved (Git 2.56) for a commit after a merge conflict.
  • Add a staged file check before the commit and a check after the commit.
  • Explain that Git does not make the commit when a hook fails, so --amend changes the previous commit. Note that hooks can be in the Git configuration (Git 2.54).
  • Do not use the experimental git history command.
  • Add a breaking change example with a scope, and the Token: value trailer format.
  • Rewrite the text in ASD-STE100 Simplified Technical English.

commit-message-storyteller

  • Remove the "commit this", "help me commit", and "generate a commit" triggers. These requests ask for a commit, and git-commit makes the commit.
  • Tell the agent that this skill does not run git commit.
  • Add the build type. Change chore to other maintenance, as in @commitlint/config-conventional.
  • Change the chore(deps) example in references/conventional-commits-guide.md to build(deps).
  • Fix the markdownlint warnings MD022, MD031, MD032, MD034, MD040, and MD060. This change is in a separate style commit.

Generated files

  • Update the descriptions in docs/README.skills.md.

Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes

  • Each command in the skill was run with Git 2.56.0: quoted and unquoted globs, git add --resolved with and without conflict markers, a failed pre-commit hook, and repeated -m options with a trailer.
  • Local checks pass: npm run skill:validate, npm start, skills-ref validate, vally lint, codespell, and markdownlint-cli2. Only MD013 (line length) remains, as in other skills.
  • I did not test the skill in GitHub Copilot, so that checkbox is not selected.

By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

- Rewrite the description with user intent triggers and exclusions.
  Exclude requests for only a commit message, which the
  commit-message-storyteller skill covers.
- Add the compatibility field. Limit allowed-tools to shell(git:*).
- Remove git add -p. Quote glob pathspecs so that they match files
  in subdirectories.
- Replace the heredoc with repeated -m options that work in all shells.
- Fix the header template to <type>(<scope>): <summary>.
- Read the repository commit rules first. State that only feat and fix
  come from Conventional Commits.
- Add git add --resolved (Git 2.56), a staged file check, and a check
  after the commit.
- Explain why --amend is incorrect after a hook fails. Note that hooks
  can be in the Git configuration.
- Add a breaking change example with a scope and the trailer format.
- Rewrite the text in ASD-STE100 Simplified Technical English.
- Update the description in docs/README.skills.md.
- Remove the "commit this", "help me commit", and "generate a commit"
  triggers. These requests ask for a commit, and the git-commit skill
  makes the commit.
- Tell the agent that this skill does not run git commit.
- Add the build type. Change chore to other maintenance, as in
  @commitlint/config-conventional.
- Change the chore(deps) example in the guide to build(deps).
- Update the description in docs/README.skills.md.
- Add the text language to fenced code blocks (MD040).
- Add blank lines around headings, fences, and lists (MD022, MD031,
  MD032).
- Put the bare URL in angle brackets (MD034).
- Align the table separator rows (MD060).
@github-actions

github-actions Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Changes 225 lines (low-risk limit is 40)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Skill validation ✅ Passed Passed · logs
Skill lint (vally) ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for 1021b80 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions github-actions Bot added the skills PR touches skills label Oct 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 3 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Vally Lint Results

✅ All checks passed

Scope Checked
Skills 2
Agents 0
Total 2
Severity Count
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ ✅ commit-message-storyteller (2/2 checks passed)
ℹ️ ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️ ✓ spec-compliance: All spec checks passed.
ℹ️ ✓ [valid-refs] All file references across 1 skill(s) are valid.
ℹ️ ✓ valid-refs: All file references resolve to existing files within the skill directory.
ℹ️ 1 skill(s) linted, 1 passed
ℹ️ ✅ git-commit (2/2 checks passed)
ℹ️ ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
ℹ️ ✓ spec-compliance: All spec checks passed.
ℹ️ ✓ [valid-refs] All file references across 1 skill(s) are valid.
Full linter output
### Linting skills/commit-message-storyteller
✅ commit-message-storyteller (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

### Linting skills/git-commit
✅ git-commit (2/2 checks passed)
    ✓ [spec-compliance] All 1 skill(s) are spec-compliant.
        ✓ spec-compliance: All spec checks passed.
    ✓ [valid-refs] All file references across 1 skill(s) are valid.
        ✓ valid-refs: All file references resolve to existing files within the skill directory.

1 skill(s) linted, 1 passed

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Oct 10, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk:medium ready-for-review Submission passed intake validation and is ready for maintainer review skills PR touches skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant