Skip to content

Remove dead stdinInteractiveOK and go-isatty direct dependency#7

Merged
bschellenberger2600 merged 1 commit into
mainfrom
cursor/fix-dead-stdin-interactive-955b
Apr 19, 2026
Merged

Remove dead stdinInteractiveOK and go-isatty direct dependency#7
bschellenberger2600 merged 1 commit into
mainfrom
cursor/fix-dead-stdin-interactive-955b

Conversation

@bschellenberger2600
Copy link
Copy Markdown
Member

Summary

Removed the unused stdinInteractiveOK helper and its tests, and dropped the direct github.com/mattn/go-isatty module require after go mod tidy.

Why this change?

stdinInteractiveOK was only referenced from cmd/root_test.go and was never called from runRainDefaultStream or any other production path. That left dead code and an unnecessary direct dependency on go-isatty.

Bug Reproducibility (if this fixes a bug)

Not a runtime bug. A repository-wide search showed no production call sites for stdinInteractiveOK.

Tests

  • I added or updated tests for all code changes in this PR. (removed tests that only covered deleted code)
  • For bug fixes, I added regression coverage.
  • I ran go test -race -count=1 ./....
  • I ran go vet ./....

Risk / Rollback Notes (optional)

Low risk: no production code path invoked the removed function. Roll back by reverting this commit if needed.

Open in Web Open in Cursor 

The helper was never called from production paths (only tests). Dropping it
removes dead code and the direct github.com/mattn/go-isatty module require.

Co-authored-by: Ben Schellenberger <bschellenberger2600@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

Warning

Rate limit exceeded

@bschellenberger2600 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 32 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 59 minutes and 32 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fc0c49da-69d5-4a2e-90fe-1c3dab41ac54

📥 Commits

Reviewing files that changed from the base of the PR and between 265e6e7 and aed1e72.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • cmd/root.go
  • cmd/root_test.go
  • go.mod
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-dead-stdin-interactive-955b

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bschellenberger2600 bschellenberger2600 marked this pull request as ready for review April 19, 2026 02:51
@bschellenberger2600
Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

✅ Actions performed

Full review triggered.

@bschellenberger2600
Copy link
Copy Markdown
Member Author

bugbot review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit aed1e72. Configure here.

@bschellenberger2600 bschellenberger2600 merged commit 129ec90 into main Apr 19, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants