Remove dead stdinInteractiveOK and go-isatty direct dependency#7
Conversation
The helper was never called from production paths (only tests). Dropping it removes dead code and the direct github.com/mattn/go-isatty module require. Co-authored-by: Ben Schellenberger <bschellenberger2600@users.noreply.github.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 59 minutes and 32 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
bugbot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit aed1e72. Configure here.
Summary
Removed the unused
stdinInteractiveOKhelper and its tests, and dropped the directgithub.com/mattn/go-isattymodule require aftergo mod tidy.Why this change?
stdinInteractiveOKwas only referenced fromcmd/root_test.goand was never called fromrunRainDefaultStreamor any other production path. That left dead code and an unnecessary direct dependency ongo-isatty.Bug Reproducibility (if this fixes a bug)
Not a runtime bug. A repository-wide search showed no production call sites for
stdinInteractiveOK.Tests
go test -race -count=1 ./....go vet ./....Risk / Rollback Notes (optional)
Low risk: no production code path invoked the removed function. Roll back by reverting this commit if needed.