fix(codex): use stable hooks feature flag#1309
Closed
oatiz wants to merge 2 commits into
Closed
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex hook installation now uses the stable
[features].hooks = trueflag instead of the deprecated[features].codex_hooks, which avoids the warning shown by current Codex Desktop builds.The installer still recognizes existing
codex_hooksconfigs so older installs are not treated as broken, but install/update migrates them to the canonicalhooksflag. Uninstall also preserves hook support when users have non-git-aihooks.jsonentries or inline[hooks]config.What Changed
hooks = truefor fresh Codex hook installs.codex_hooksas a legacy compatibility alias during checks.codex_hooksduring install/update migration.notify, customhooks.jsonentries, and inline[hooks]config.hooks = true.Testing
cargo fmt --checkcargo test codex --libcargo test install_hooks --test integration