chore: fully remove git wrapper#1291
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…normalizer Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the git client installer infrastructure (Fork, Sublime Merge) that configured GUI clients to use the git-ai wrapper as their git binary. Also remove the git.path setting from Cursor and VS Code installers since the wrapper is no longer needed. The daemon's trace2 integration still captures operations from these clients. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The WrapperDaemon test mode simulated the wrapper sending state to the daemon. Since the wrapper is fully removed, this mode is obsolete. Tests now only run in Daemon mode. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove ENV_SKIP_MANAGED_HOOKS constant, resolve_previous_non_managed_hooks_path, has_repo_hook_state, should_forward_repo_state_first, and related helper functions that were only used by the old git wrapper. Fix formatting issues flagged by rustfmt. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The inline post-commit stats display was a wrapper feature that polled the daemon for authorship notes after commit. With the wrapper removed, this functionality no longer exists in the thin proxy. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Devin Review found 2 potential issues.
⚠️ 1 issue in files not directly in the diff
⚠️ AGENTS.md still references removed task test:wrapper-daemon command (AGENTS.md:22)
AGENTS.md line 22 still documents task test:wrapper-daemon as a valid test command, but this task was removed from Taskfile.yml in this PR. Per the repository's rules in AGENTS.md, this is the canonical reference for build & test commands. Anyone (human or AI agent) following these instructions will encounter a task-not-found error when trying to run task test:wrapper-daemon.
View 6 additional findings in Devin Review.
| println!("No compatible coding agents detected. Nothing to install."); | ||
| } |
There was a problem hiding this comment.
🟡 Duplicate 'No compatible coding agents detected' message printed during install-hooks
After removing the Git Clients section from async_run_install, there are now two consecutive if !any_checked blocks at src/commands/install_hooks.rs:613-615 and src/commands/install_hooks.rs:617-618. When no coding agents are detected (any_checked == false), the message "No compatible coding agents detected. Nothing to install." is printed twice. The first block was the guard at the end of the Coding Agents section, and the second was the combined guard that previously appeared after both Coding Agents and Git Clients sections. The Git Clients section removal should have also removed the first duplicate block.
(Refers to lines 613-615)
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
git_handlers.rs) with a ~120-line thin proxy that just spawns git and forwards args/exit code — kept only for legacy installations that still invoke git-ai as "git"WrapperPreState/WrapperPostStatecontrol requests,wrapper_statesHashMap,apply_wrapper_state_overlaytimeout logic,wrapper_invocation_idfield fromNormalizedCommandinstall.sh: no more git/git-og symlinks, no more shell profile PATH manipulation (bashrc/zshrc/fish)git_shim_pathutilities — trace2 handles these clients nativelyWrapperDaemontest mode andtest:wrapper-daemonTaskfile taskTest plan
cargo fmtclean🤖 Generated with Claude Code