Add tools for perf analysis#1215
Closed
desiderautumn wants to merge 1 commit into
Closed
Conversation
|
|
||
| The `mod.rs` file is a Rust module that wraps the execution of | ||
| subprocesses executed via `Command::output` and `Command::status`, | ||
| via the `measured_output` and `measured_stats` wrappers. |
Contributor
There was a problem hiding this comment.
🟡 README typo: measured_stats should be measured_status
The README on line 7 refers to the wrapper as measured_stats, but the actual trait method is named measured_status (as correctly documented on line 12 and implemented in src/perf/mod.rs:13). This will confuse developers trying to use the API based on the README.
Suggested change
| via the `measured_output` and `measured_stats` wrappers. | |
| via the `measured_output` and `measured_status` wrappers. |
Was this helpful? React with 👍 or 👎 to provide feedback.
Member
|
@heapwolf See if you'd like to merge or cherry-pick from here for any perf stuff -- esp for Windows. Ideally we can have a harness that would live inside our codebase for easy profiling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds tooling for analyzing the performance overhead of spawning subprocesses. See
src/perf/README.mdfor documentation.Example output on Linux (of
cargo run diff @..f296d):On Windows: