fix: PR #9 review fixes + full codebase audit — reviewed by Raven (Giggso)#10
Merged
Merged
Conversation
- scan_tools_code: replace Path.rglob with os.scandir + early pruning - scan_repo_discovery: v2 multi-OS walker (6-rule algorithm, all drives) - setup_agent.ps1: ExecutionTimeLimit PT2M to PT10M - repo_discovery.yaml: updated config for v2 walker - test fixes: encoding, MAX_PATH, new regression coverage Tested: 22 unit tests pass, 355 full suite, e2e 3.06s on 113 repos
…ndling
- Add missing 'import platform as _platform' (P2)
- Add WSL1 detection fallback using os.environ.get('WSL_DISTRO_NAME') (P1)
- Improve Windows drive type check error handling for WSL2 compat (P2)
- Verify macOS gcloud exclusion via absolute path check (P1)
All 13 regression tests pass. Fixes giggsoinc#8 Raven feedback.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…Raven (Giggso) PR giggsoinc#9 original fixes (5): - PowerShell param() block moved before ErrorActionPreference - Removed A/B TEST debug header from scan_repo_discovery.py.frag - Removed 63-line v1.0.0 rollback block from scan_repo_discovery.py.frag - Corrected _REPO_MAX_SECONDS tunable comment - Added multi-process safety NOTE to _catalog_lock in agent_store.py PowerShell template hardening (8): - 5x UTF-8 BOM fix: Set-Content replaced with Write-Utf8NoBom helper - 2x depth fix: -Depth 4 to -Depth 6 to match _REPO_MAX_DEPTH=6 - 1x TmpMeta security: try/finally ensures OTP hash temp file always deleted Full codebase audit via Raven Enterprise (shadow mode) - 133 issues resolved: - 87 bare/broad except clauses annotated across frags, dashboard, src/ - 3 files refactored into sub-modules (hourly_rollup, rollup_reader, agent_store) New: _rollup_agg.py, _rollup_s3.py, _rollup_scheduler.py, _rollup_merge.py, _agent_otp.py - 7 LOC-exempt files: architectural justification documented in source - 4 test files: loc-exempt markers removed (policy: cap is production-only) - 2 false-positive SECRET annotations added for AWS docs example keys - Dead-marker and hack comments cleaned in chat/engine.py and chat/tools.py - Fragment globals documented in scan_header.py.frag Test results: 444 passed, 1 skipped, 0 failures Integration errors: 14 pre-existing (require LocalStack, unrelated to changes) Supersedes: PR giggsoinc#7, PR giggsoinc#8, PR giggsoinc#9 Reviewed by: Raven Enterprise (shadow mode) - Giggso Inc Report: docs/full_fix_verification_report.pdf Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates and supersedes PR #7, PR #8, and PR #9 with all identified review issues resolved and a full codebase audit completed — reviewed end-to-end by Raven Enterprise (Giggso, shadow mode).
PR #9 Original Fixes (5)
setup_agent.ps1.template—param()block moved before$ErrorActionPreferencescan_repo_discovery.py.frag— A/B TEST debug header removedscan_repo_discovery.py.frag— 63-line v1.0.0 rollback block removedscan_repo_discovery.py.frag—_REPO_MAX_SECONDStunable comment correctedsrc/store/agent_store.py— multi-process safety NOTE added to_catalog_lockPowerShell Template Hardening (8 fixes)
Set-Content -Encoding UTF8replaced withWrite-Utf8NoBomhelper-Depth 4to-Depth 6(matches_REPO_MAX_DEPTH = 6)try/finallyguarantees OTP hash temp file is always deletedFull Codebase Audit — 133 issues resolved
Reviewed by Raven Enterprise (Giggso Inc, shadow mode):
exceptclauses annotated across agent frags, dashboard UI, andsrc/hourly_rollup.pysplit into_rollup_agg.py,_rollup_s3.py,_rollup_scheduler.pyrollup_reader.pysplit into_rollup_merge.pyagent_store.pyOTP helpers extracted to_agent_otp.pyloc-exemptmarkers removed (Raven policy: LOC cap is production-code only)SECRETannotations added for AWS documentation example keys in testschat/engine.pyandchat/tools.pyscan_header.py.fragTest Results
Full verification report:
ghost-ai-scanner/docs/full_fix_verification_report.pdfFiles Changed
67 files: 57 modified + 10 new (5 sub-modules + 5 docs/reports)
Supersedes
Closes #7 — Cross-platform installer fixes (included here)
Closes #8 — Scan pipeline performance (included here)
Closes #9 — PR #9 base branch (all fixes applied + full audit on top)
Reviewed by: Raven Enterprise — Giggso Inc (shadow mode)
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com