Skip to content

cli : load backends after validating input files - #4069

Merged
danbev merged 2 commits into
ggml-org:masterfrom
erikdw:cli-validate-before-backends
Sep 18, 2026
Merged

danbev merged 2 commits into
ggml-org:masterfrom
erikdw:cli-validate-before-backends

Conversation

@erikdw

@erikdw erikdw commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

I noticed that expensive operations (e.g., compiling shaders) are done prior to checking if the input file even exists.

Solution:

  • Move backend loading after the input-file checks so we can fail early.
  • Also fail early if the model path is missing.

Note

AI assistant used to locate the call and apply the move. I can discuss the change.

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
Comment thread examples/cli/cli.cpp Outdated
Co-authored-by: Cursor <cursoragent@cursor.com>
@danbev

danbev commented Sep 18, 2026

Copy link
Copy Markdown
Member

The failing android CI jobs were fixed as part of 4afa009.

@danbev
danbev merged commit b27fbff into ggml-org:master Sep 18, 2026
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants