CPU/Windows: Ensure LLVMs OpenMP library gets selected in CMake and CI#25782
Draft
JTischbein wants to merge 1 commit into
Draft
CPU/Windows: Ensure LLVMs OpenMP library gets selected in CMake and CI#25782JTischbein wants to merge 1 commit into
JTischbein wants to merge 1 commit into
Conversation
github-actions
Bot
added
build
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Right now the Windows build uses the debug non-redistributable DLL of OpenMP from MSVC and Visual Studio does not ship a distributable DLL. LLVM on the other hand does ship one.
This PR changes the build toolchain for Windows on Arm to use the LLVM OpenMP DLL (libomp.dll) and changes the CI to package the LLVM \Llvm\ARM64\bin\libomp.dll instead of the MSVC/.../debug_nonredist/.../libomp140.aarch64.dll
Requirements