SPTECH-474: document q validation rules and invalid-parameter 400 - #119
Merged
Conversation
The implementation has always rejected q values longer than 150 chars with a 400, and getyourguide/public-partner-api#1975 adds the same rejection for q values that contain no letters or numbers (previously an off-contract 503). Document both rules on the q parameter and widen the ToursQuery 400 description accordingly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
clue-gyg
approved these changes
Aug 3, 2026
clue-gyg
left a comment
clue-gyg
left a comment
There was a problem hiding this comment.
✅ Auto-approved as trivial change
Tiny 2-line diff (description-only text changes) in an OpenAPI spec, documenting existing production validation behavior and the 400 response for invalid 'q' values — no schema/type/contract changes, well under the 50-line limit.
clue-gyg
approved these changes
Aug 3, 2026
clue-gyg
left a comment
clue-gyg
left a comment
There was a problem hiding this comment.
✅ Auto-approved as trivial change
Documentation-only change (2 lines modified across two YAML description fields) that clarifies existing 'q' parameter validation and 400 error description to match actual production behavior; no schema/type changes, no new endpoints, no security-sensitive files touched, well under the 50-line limit.
arihantgupta-28
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SPTECH-474:
GET /{version}/toursreturned an off-contract 503 whenqcontained no searchable characters (bot probes likeq='..';.';.';.'./'). getyourguide/public-partner-api#1975 fixes that to a proper 400. This PR aligns the public spec with actual behavior.Changes
qparameter (spec/components/commons/query.yaml): document that it must contain at least one letter or number, that special characters are ignored, and the 150-character maximum — the length limit has been enforced in production for a long time but was never documented.spec/paths/tours.yaml): "Missing Parameters" → "Missing or invalid parameters", with theqrules as example.No schema/type changes — description-only, so generated clients are unaffected.
🤖 Generated with Claude Code