Skip to content

functions dataset: add max_execution_time#7931

Merged
xurui-c merged 1 commit into
masterfrom
rachel/functions
May 8, 2026
Merged

functions dataset: add max_execution_time#7931
xurui-c merged 1 commit into
masterfrom
rachel/functions

Conversation

@xurui-c
Copy link
Copy Markdown
Member

@xurui-c xurui-c commented May 8, 2026

No description provided.

@xurui-c xurui-c marked this pull request as ready for review May 8, 2026 20:18
@xurui-c xurui-c requested a review from a team as a code owner May 8, 2026 20:18
Copilot AI review requested due to automatic review settings May 8, 2026 20:18
@xurui-c xurui-c requested a review from a team as a code owner May 8, 2026 20:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a ClickHouse settings override query processor to the functions readable storage configuration to apply a default execution timeout policy at query time.

Changes:

  • Add a query_processors block to the functions storage.
  • Configure ClickhouseSettingsOverride to apply max_execution_time: 25 (and related settings) without overwriting any per-query settings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@thetruecpaul thetruecpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incident ongoing — approving to unblock potential fix.

@xurui-c xurui-c enabled auto-merge (squash) May 8, 2026 21:11
@xurui-c xurui-c merged commit b0934b2 into master May 8, 2026
53 checks passed
@xurui-c xurui-c deleted the rachel/functions branch May 8, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants