Ensure SENTRY_OPTIONS_DIR/values exists in final image#7917
Open
aminvakil wants to merge 3 commits intogetsentry:masterfrom
Open
Ensure SENTRY_OPTIONS_DIR/values exists in final image#7917aminvakil wants to merge 3 commits intogetsentry:masterfrom
aminvakil wants to merge 3 commits intogetsentry:masterfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 05edf92. Configure here.
aminvakil
changed the title
Collaborator
|
From @hubertdeng123 we merged in a change to remove the logs there, instead i was going to cut a release and bump the li rary |
aminvakil
force-pushed
the
ensure_SENTRY_OPTIONS_DIR_exists
branch
from
01569da to
4dd6528
Compare
Member
|
This is the change in question: getsentry/sentry-options#121 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes getsentry/self-hosted#4306
Since 5b63073 final image does not contain
/etc/sentry-optionsanymore, and so it floods logs withFailed to read directory /etc/sentry-options/values: No such file or directory (os error 2)because of that.This PR ensures the env exists.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.