fix(anomaly detection): don't allow enable anomaly detection on free/team plan #106985
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const hasAnomalyDetectionFeature = organization.features.includes( | ||
| 'anomaly-detection-alerts' | ||
| ); | ||
| const requiresUpgrade = isAnomalyDetector && !hasAnomalyDetectionFeature; |
There was a problem hiding this comment.
Duplicated anomaly detector check logic across files
Low Severity
The logic for isAnomalyDetector, hasAnomalyDetectionFeature, and requiresUpgrade is identically duplicated in both actions.tsx and disabledAlert.tsx. If the feature flag name 'anomaly-detection-alerts' or the detection type check ever needs to change, it would require updating both files separately, risking inconsistency. This logic could be extracted into a shared utility function in the utils directory, similar to the existing anomalyDetectionLabels.tsx utilities.
Additional Locations (1)
|
this should be done in getsentry instead |
Free/team plans can enable dynamic detectors that already exist on a project, which should not be possible. Changed banner to say "Anomaly detection is only available on Business and Enterprise plans. Upgrade your plan to enable this monitor." and disabled
enablebutton.no
anomaly-detection-alertswith
anomaly-detection-alerts