Skip to content

chore(billing): Remove seer-user-billing flag #106982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendanhsentry merged 3 commits into from
Jan 27, 2026
Merged

chore(billing): Remove seer-user-billing flag #106982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e64f83f
chore(billing): Remove seer-user-billing flag
brendanhsentry Jan 23, 2026
dd5c52c
clean up all references
brendanhsentry Jan 23, 2026
97652bb
clean up some more tests
brendanhsentry Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions static/app/utils/seer/showNewSeer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('showNewSeer', () => {

it('returns false even with launch flags when seer-added is present', () => {
const organization = OrganizationFixture({
features: ['seer-added', 'seer-user-billing', 'seer-user-billing-launch'],
features: ['seer-added', 'seer-user-billing-launch'],
});

expect(showNewSeer(organization)).toBe(false);
Expand All @@ -42,36 +42,20 @@ describe('showNewSeer', () => {

it('returns false even with launch flags when code-review-beta is present', () => {
const organization = OrganizationFixture({
features: ['code-review-beta', 'seer-user-billing', 'seer-user-billing-launch'],
features: ['code-review-beta', 'seer-user-billing-launch'],
});

expect(showNewSeer(organization)).toBe(false);
});
});

describe('seer-user-billing-launch flag', () => {
it('returns true when both seer-user-billing and seer-user-billing-launch are present', () => {
const organization = OrganizationFixture({
features: ['seer-user-billing', 'seer-user-billing-launch'],
});

expect(showNewSeer(organization)).toBe(true);
});

it('returns false when only seer-user-billing is present', () => {
const organization = OrganizationFixture({
features: ['seer-user-billing'],
});

expect(showNewSeer(organization)).toBe(false);
});

it('returns false when only seer-user-billing-launch is present', () => {
it('returns true when seer-user-billing-launch is present', () => {
const organization = OrganizationFixture({
features: ['seer-user-billing-launch'],
});

expect(showNewSeer(organization)).toBe(false);
expect(showNewSeer(organization)).toBe(true);
});
});

Expand Down
5 changes: 1 addition & 4 deletions static/app/utils/seer/showNewSeer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@ export default function showNewSeer(organization: Organization) {
}

// This is the launch flag
if (
organization.features.includes('seer-user-billing') &&
organization.features.includes('seer-user-billing-launch')
) {
if (organization.features.includes('seer-user-billing-launch')) {
return true;
}

Expand Down
1 change: 0 additions & 1 deletion static/app/views/settings/account/notifications/notificationSettingsByType.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ describe('NotificationSettingsByType', () => {
'continuous-profiling-billing',
'seer-billing',
'logs-billing',
'seer-user-billing',
'seer-user-billing-launch',
],
});
Expand Down
6 changes: 2 additions & 4 deletions static/app/views/settings/account/notifications/notificationSettingsByType.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,8 @@ export function NotificationSettingsByType({notificationType}: Props) {
organization.features?.includes('logs-billing')
);

const hasSeerUserBilling = organizations.some(
organization =>
organization.features?.includes('seer-user-billing') &&
organization.features?.includes('seer-user-billing-launch')
const hasSeerUserBilling = organizations.some(organization =>
organization.features?.includes('seer-user-billing-launch')
);

const excludeTransactions = hasOrgWithAm3 && !hasOrgWithoutAm3;
Expand Down
Loading