Clean up staff feature flag
#106966
Draft
Clean up staff feature flag
#106966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Remove the staff.ga-rollout feature flag and related code now that the staff permissions system has been fully rolled out. This includes: - Remove staff.ga-rollout and staff.user-email-allowlist options - Remove has_staff_option() helper function - Simplify has_elevated_mode() to always use staff permissions - Update SuperuserOrStaffFeatureFlaggedPermission to always use staff - Simplify permission checks across relocation and user endpoints - Remove conditional logic that checked the feature flag All code now assumes staff permissions are enabled, eliminating the technical debt from the gradual rollout process.
Since we've migrated staff.ga-rollout and removed the flag, this means that the staff user should take the place of the old superuser flag. Updating the tests to reflect this. There were a lot of superuser uses still left in the code.
This permission is no longer relevant, and we should just use the StaffPermission. Remove all uses of this.
michelletran-sentry
force-pushed
the
cleanup-staff-ga-options
branch
from
18dd182 to
3469a97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature flag looks to have been GA'ed. I'm going to attempt to remove the feature flag and clean up the code.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.