feat(preprod): Use structured search#106961
Conversation
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/views/releases/detail/commitsAndFiles/preprodBuilds.tsx
Outdated
Show resolved
Hide resolved
chromy
force-pushed
the
chromy/2026-01-26-use-structured-search
branch
from
608b5cb to
ca305e1
Compare
chromy
force-pushed
the
chromy/2026-01-26-use-structured-search
branch
from
ca305e1 to
ace4d8e
Compare
chromy
force-pushed
the
chromy/2026-01-26-use-structured-search
branch
2 times, most recently
from
fafaf19 to
4855d5c
Compare
static/app/views/releases/detail/commitsAndFiles/preprodBuilds.tsx
Outdated
Show resolved
Hide resolved
chromy
force-pushed
the
chromy/2026-01-26-use-structured-search
branch
from
4855d5c to
7bceb89
Compare
chromy
force-pushed
the
chromy/2026-01-26-use-structured-search
branch
from
7bceb89 to
462f4c3
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| projects={[Number(projectId)]} | ||
| onChange={handleSearch} | ||
| onDisplayChange={handleDisplayChange} | ||
| /> |
There was a problem hiding this comment.
Search bar won't sync with external URL changes
Medium Severity
The migration from SearchBar (controlled with query prop) to SearchQueryBuilder (uncontrolled with initialQuery prop) breaks synchronization when the URL changes externally. The old SearchBar had a useEffect that synced internal state with prop changes, but SearchQueryBuilder only uses initialQuery for initialization. When users navigate via browser back/forward buttons or receive a shared URL, the API will fetch the correct results but the search bar will display the stale query text, causing a confusing UI/data mismatch.
Additional Locations (1)
There was a problem hiding this comment.
the URL parsing is working but admittedly the URL looks super weird
lol not sure why that would happen
edit: tried to see if I could do a quick fix and i think we should just leave this as is 👍
|
did some testing and the component is really nice! the only regression i found was https://linear.app/getsentry/issue/EME-752/add-specific-build-id-support-to-list-builds-endpoint no longer works (something I landed 4 days ago) but i bet we could add support for it again |
| projects={[Number(projectId)]} | ||
| onChange={handleSearch} | ||
| onDisplayChange={handleDisplayChange} | ||
| /> |
There was a problem hiding this comment.
the URL parsing is working but admittedly the URL looks super weird
lol not sure why that would happen
edit: tried to see if I could do a quick fix and i think we should just leave this as is 👍
fixed this #107118 |
2 participants
No description provided.