Skip to content

build(deps): Pin decode-uri-component to patched 0.5.1 to resolve DoS advisory #6975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
antonis wants to merge 1 commit into from
Closed

build(deps): Pin decode-uri-component to patched 0.5.1 to resolve DoS advisory #6975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@
"glob@npm:^10.4.2": "^10.5.0",
"axios": "^1.20.0",
"follow-redirects": "^1.16.1",
"decode-uri-component": "^0.5.1",

@cursor cursor Bot Oct 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESM override breaks query-string

High Severity

The decode-uri-component resolution jumps to 0.5.1, but that release is ESM-only with a default export. query-string@7.1.3 still requires a CommonJS callable, so the override yields a module namespace and TypeError: decodeComponent is not a function when React Navigation or expo-router parse query strings in the sample apps.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

Reviewed by Cursor Bugbot for commit 467b314. Configure here.

@antonis antonis Oct 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — confirmed. decode-uri-component went ESM-only in 0.4.0, and query-string@7.1.3 loads it via a CommonJS require(), so forcing 0.5.1 yields a non-callable module namespace and decodeComponent is not a function when the sample apps parse query strings.

There's no CJS-compatible patched release — 0.2.2 is the last CommonJS version, and every fixed release (0.4+/0.5) is ESM-only. Since this is sample-app-only (query-string ← @react-navigation), DoS-only, and not part of the shipped @sentry/react-native, we're dismissing the Dependabot alert as tolerable risk and closing this PR rather than shipping a broken override.

"fast-xml-parser": "^5.7.0",
"form-data": "4.0.6",
"qs": "^6.17.0",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12337,10 +12337,10 @@ __metadata:
languageName: node
linkType: hard

"decode-uri-component@npm:^0.2.2":
version: 0.2.2
resolution: "decode-uri-component@npm:0.2.2"
checksum: 10c0/1f4fa54eb740414a816b3f6c24818fbfcabd74ac478391e9f4e2282c994127db02010ce804f3d08e38255493cfe68608b3f5c8e09fd6efc4ae46c807691f7a31
"decode-uri-component@npm:^0.5.1":
version: 0.5.1
resolution: "decode-uri-component@npm:0.5.1"
checksum: 10c0/70e30722bb8671c9795a1301bd20b12e6011a401a8703becf480846c3ad13e8c6ee3c9cbd2b3a82532197eb4d422f54b1151b9a617d8ec3b74874fac1e87e14c
languageName: node
linkType: hard

Expand Down
Loading