Repository navigation
fix(android): Restore enableLogs option mapping - #6967
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0b6915b. Configure here.
antonis
marked this pull request as ready for review
October 29, 2026 14:41
antonis
requested review from
alwx and
buenaflor
and removed request for
a team
October 29, 2026 14:41
📲 Install BuildsAndroid
|
alwx
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Restores the
enableLogs→options.getLogs().setEnabled(...)mapping inRNSentryStart.getSentryAndroidOptions. It goes back in its original place, right afterenableNdk.Both Android init paths read options through
getSentryAndroidOptions, so this one change fixes both:initNativeSdk→RNSentryModuleImpl→RNSentryStart.startWithOptions. Old and New Architecture share this path.RNSentrySDK.init(start before JS, options fromsentry.options.json) →RNSentryStart.startWithOptions💡 Motivation and Context
Since v8,
Sentry.init({ enableLogs: true })has had no effect on the native Android SDK💚 How did you test it?
RNSentryStartTest.kt:enableLogs: true,enableLogs: false, and key absent (the native default is left unchanged).true/falsetests fail without the fix (2 failures) and pass with it (37/37).yarn lint:lerna.yarn lint:androidandyarn lint:kotlinshow no issues in the changed files (the only failures are in generated/local build output).📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps