Repository navigation
Conversation
Contributor
size-limit report 📦Compared: c7b4e2d (PR test merge using develop at a2dbec0) Against: a2dbec0 (develop) · base run #65070 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 not successful, 50 successful. See the run.
Successful checks
|
Member
|
are there other relevant changes in nx itself (for us) between 22 and 24? |
chargome
force-pushed
the
fix/dependabot-axios-nx
branch
from
November 4, 2026 19:36
5ba5623 to
0bb9d41
Compare
Member
Author
|
@mydea it drops node 20 but our tests still pass so not blocking imo |
chargome
added a commit
that referenced
this pull request
Nov 5, 2026
**Why:** Fixes the open follow-redirects advisories (3 high). Lockfile only, since the parents use `^` ranges. The remaining 1.16.0 copy comes from `axios@1.18.1` in nx 22 and goes away with #26110. Dependabot alert: https://github.com/getsentry/sentry-javascript/security/dependabot/3402 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
nx 22 pins a vulnerable axios. nx 24 drops axios entirely. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chargome
force-pushed
the
fix/dependabot-axios-nx
branch
from
November 5, 2026 12:16
0bb9d41 to
33630fd
Compare
chargome
marked this pull request as ready for review
November 5, 2026 14:08
chargome
requested review from
Lms24,
andreiborza,
logaretm,
mydea and
s1gr1d
and removed request for
a team
November 5, 2026 14:08
chargome
changed the title
chargome
requested review from
nicohrubec
and removed request for
logaretm,
mydea and
s1gr1d
November 5, 2026 14:08
andreiborza
approved these changes
Nov 5, 2026
nicohrubec
approved these changes
Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: nx 22 pins
axios@1.18.1, which has open advisories, and every 22.x release does. nx 24 drops axios. We skip nx 23 because it pinsundici@7.29.0, which is still vulnerable, while 24.0.3 pins the patched 7.30.1. 24.0.4 is too new for ourminimumReleaseAge. Dependabot alert: https://github.com/getsentry/sentry-javascript/security/dependabot/3311How to review: The only config change is
affected.legacy: true, added by the official nx 24 migration sonx affected(test:pr) keeps selecting whole projects instead of individual tasks. The other nx 23/24 migrations made no changes.Unsure about: nx 23 dropped Node 20 support, but our
Node (20.19) Unit Testsjob still runs nx on Node 20 (throughtest:pr:node). It passes today and nx declares noengines, so nothing blocks it, but a future nx release could break that job. If that happens, the job would need to run nx on the repo's Node version and only the tests on Node 20.