Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #26077
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
sentry-junior
Bot
requested review from
Lms24,
isaacs,
logaretm,
mydea and
s1gr1d
and removed request for
a team
November 3, 2026 21:18
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Contributor
size-limit report 📦Compared: c237c57 (PR test merge using develop at b9d0f82) Against: b9d0f82 (develop) · base run #64907 ✅ Baseline matches: this diff contains only this PR's changes.
|
logaretm
approved these changes
Nov 3, 2026
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 6 not successful, 49 successful. See the run.
Successful checks
|
sentry-junior
Bot
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: This bumps the pinned
getsentry/craftaction inrelease.ymlandauto-release.ymlfrom 3.5.0 (3f1f02d) to 3.9.0 (2e29b08). Craft's "Check release blockers" step used to call the async run-cancel API and then exit 0. The action kept going and opened a getsentry/publish issue even whilerelease-blockerissues were open (see https://github.com/getsentry/symbolic/actions/runs/41665569364). getsentry/craft#956 fixed this, and the fix shipped in Craft 3.9.0. Older pins do not have it. This is the same change as getsentry/symbolic#1134.This repo is already on Craft 3.x, so there are no new breaking changes. The inputs used here (
merge_target,craft_config_from_merge_target, etc.) still exist in 3.9.0. Before this change, I rancraft prepare 99.0.0 --dry-run --no-input --no-pushwith the 3.9.0 release binary ondevelop. Ondevelopas-is, it stops with "No changelog entry found for version 99.0.0". That is expected withchangelog.policy: simplewhile the top heading is## Unreleased. I renamed that heading to## 99.0.0in a throwaway local commit and ran it again. The dry run finished, includingscripts/craft-pre-release.sh(pnpm install, version bump, lockfile update).There are no open
release-blockerissues in this repo right now. After this lands, an open one stops a release before Craft prepares it.Config changes:
minVersion'0.23.1' -> '3.9.0'. Addedversioning.policy: manual: with aminVersionbelow 2.14.0 the default wasmanual, and at 3.9.0 it would becomeauto. Both workflows setcraft_config_from_merge_target: true, so this.craft.ymlis used oncedevelopis merged intomaster. Until then, Craft 3.9.0 uses the currentmasterconfig, which the dry run above covers. After the change, the 3.9.0 dry run bumps the same 83 files as before, with the same changelog workaround. There are no new errors.How to review: Two one-line pin changes, plus the small
.craft.ymlchange.via @BYK.
--
View Session in Sentry