fix(config): Only warn about deprecated hackney options when explicitly configured#985
Merged
solnic merged 1 commit intogetsentry:masterfrom Feb 6, 2026
Merged
Conversation
…ly configured Remove the `deprecated:` directive from hackney options in NimbleOptions schema and handle deprecation warnings manually. This ensures warnings are only shown when users explicitly configure hackney options, not when using default values with the Finch client. Add tests to verify the warning behavior. Fixes getsentryGH-984 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
zeminlu
force-pushed
the
fix/hackney-warnings
branch
from
bf1e18c to
5d9eddb
Compare
solnic
approved these changes
Feb 6, 2026
Collaborator
solnic
left a comment
solnic
left a comment
There was a problem hiding this comment.
This is super helpful, thank you!!!! <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deprecated:directive from hackney options in NimbleOptions schemaTest plan
Fixes #984
🤖 Generated with Claude Code
#skip-changelog