-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs(self-hosted): Update troubleshooting Docker healthcheck (clarify unhealthy container troubleshooting on slower systems) #17149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arsalanyavari
wants to merge
5
commits into
getsentry:master
Choose a base branch
from
arsalanyavari:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−1
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
798c5fa
Update troubleshooting Docker healthcheck
arsalanyavari 6a09912
Update develop-docs/self-hosted/troubleshooting/docker.mdx remove ext…
arsalanyavari 47a4f58
Revise Docker troubleshooting notes for healthchecks
arsalanyavari 4dfc3e2
Fix formatting in troubleshooting Docker documentation
arsalanyavari 63fddcd
Update docker.mdx
aldy505 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The troubleshooting guide for Docker healthchecks is incomplete. It instructs creating
.env.custombut omits the required--env-fileflag in thedocker composecommand, rendering the fix ineffective.Severity: MEDIUM
Suggested Fix
Replace the vague instruction "Then start Docker Compose." with the explicit command required to load the custom environment file, such as
docker compose --env-file .env --env-file .env.custom up --wait. This ensures theHEALTHCHECK_RETRIESoverride is correctly applied.Prompt for AI Agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arsalanyavari does this review make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergical I think this sentence is enough. There’s no need to explain how to start Docker Compose again, since it’s already mentioned above and in the main documentation based on @aldy505 contribution to this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think it’s necessary to mention this again, we can repeat that line as well (or I can move the Docker Compose start command closer to this section instead).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i mean more so the part about creating a new .env.custom file. Can the healthcheck value not go into the existing .env file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergical we actually don't suggest users to update the
.envfile. If they want to add more changes, they should do so on.env.customordocker-compose.override.yml, both are gitignored.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergical do you think I still need to make any changes for the PR to be approved and merged, or based on @aldy505 explanation, is there nothing else I need to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as long as it's clear to the user that
docker compose --env-file .env --env-file .env.custom up --waitis what should be run when they have a custom env file, im good with it