ref(docs): Use dynamic version for Android Gradle plugin in upload instructions (EME-758) #16147
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structions (EME-758) Replace hardcoded version (6.0.0-rc.1) with dynamic version fetched from package registry. This ensures the docs always show the latest available version for size analysis and build distribution features. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Use optional chaining to handle case where packageRegistry.data might be null, consistent with other components like PlatformSdkDetail and JsBundleList. Co-Authored-By: Claude <noreply@anthropic.com>
runningcode
commented
Jan 26, 2026
| export async function GradleUploadInstructions({feature}: Props) { | ||
| const featureName = feature === 'sizeAnalysis' ? 'size analysis' : 'distribution'; | ||
|
|
||
| const packageRegistry = await getPackageRegistry(); |
Contributor
Author
There was a problem hiding this comment.
the mdx injection doesn't work here since this is a tsx file so this is the best solution i could come up with.
this code is used for size analysis and build distribution
Contributor
|
I think we need to add something else if we do this: Line 672 in 77e43a0 but maybe we can use: |
Adds GradleUploadInstructions to the registry dependency detection in mdx.ts so that MDX files using this component are properly cache invalidated when the Release Registry data changes. Also updates the fallback version to 7.12.3 for testing. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
Nice catch @chromy! I've updated the PR |
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the size analysis and build distribution documentation to use dynamic version fetching for the Sentry Android Gradle plugin instead of a hardcoded version.
Fixes EME-758