chore: pin GitHub Actions to full-length commit SHAs#5760
chore: pin GitHub Actions to full-length commit SHAs#5760
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| steps: | ||
| - name: Run Sentry self-hosted e2e CI | ||
| uses: getsentry/self-hosted@master | ||
| uses: getsentry/self-hosted@871c182cb0a99dc1fad72cc7ce7889b514b0c5f0 # master |
There was a problem hiding this comment.
Hardcoded path breaks after SHA pinning of self-hosted action
Medium Severity
Pinning getsentry/self-hosted from @master to @871c182cb0a99dc1fad72cc7ce7889b514b0c5f0 changes the directory where GitHub Actions stores the downloaded action from .../self-hosted/master to .../self-hosted/871c182cb0a99dc1fad72cc7ce7889b514b0c5f0. The Inspect failure step on line 899 still hardcodes cd /home/runner/work/_actions/getsentry/self-hosted/master, which will now fail with "no such file or directory," preventing collection of debugging output when the e2e tests fail.
geoffg-sentry
left a comment
geoffg-sentry
left a comment
There was a problem hiding this comment.
cursor makes a point worth reviewing for self-hosted
2 participants
Summary
.github/workflow files to full-length commit SHAsGenerated by
devenv pin_gha.🤖 Generated with Claude Code