feat(managed): Add logic so retain can be used both on vec and smallvec#5753
Draft
tobias-wilfert wants to merge 1 commit intomasterfrom
Draft
feat(managed): Add logic so retain can be used both on vec and smallvec#5753tobias-wilfert wants to merge 1 commit intomasterfrom
tobias-wilfert wants to merge 1 commit intomasterfrom
Conversation
jjbayer
approved these changes
Mar 20, 2026
Comment on lines
+169
to
+176
| fn retain_mut(&mut self, f: impl FnMut(&mut I) -> bool) { | ||
| Vec::retain_mut(self, f); | ||
| } | ||
| } | ||
| impl<I, const N: usize> RetainMut<I> for SmallVec<[I; N]> { | ||
| fn retain_mut(&mut self, f: impl FnMut(&mut I) -> bool) { | ||
| SmallVec::retain_mut(self, f); | ||
| } |
Member
There was a problem hiding this comment.
nit: Make explicit that the wrapper and the underlying function have the same return type.
Suggested change
| fn retain_mut(&mut self, f: impl FnMut(&mut I) -> bool) { | |
| Vec::retain_mut(self, f); | |
| } | |
| } | |
| impl<I, const N: usize> RetainMut<I> for SmallVec<[I; N]> { | |
| fn retain_mut(&mut self, f: impl FnMut(&mut I) -> bool) { | |
| SmallVec::retain_mut(self, f); | |
| } | |
| fn retain_mut(&mut self, f: impl FnMut(&mut I) -> bool) { | |
| Vec::retain_mut(self, f) | |
| } | |
| } | |
| impl<I, const N: usize> RetainMut<I> for SmallVec<[I; N]> { | |
| fn retain_mut(&mut self, f: impl FnMut(&mut I) -> bool) { | |
| SmallVec::retain_mut(self, f) | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #5747 I would ideally have something like this irregardles of if attachments are a vec or a smallvec (items):