fix(incidents): Skip paging and on-call invites for private incidents#252
Merged
Conversation
Private incidents previously paged IMOC and invited IMOC on-call users to the Slack channel. They now skip all PagerDuty paging and on-call invitations entirely, keeping private incidents fully contained to their creator and explicitly added participants. Co-Authored-By: Claude <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/KI4U9WHWjxRHLxRxvnHGIqjR31Hovh0-f6Ps1pFX-1w
Co-Authored-By: Claude <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/DmKjnSM5kOeNpn8Y9NnSZYpXNh9elIu0oZbM6NSohHI
spalmurray
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private incidents previously paged IMOC and invited IMOC on-call users to the Slack channel. This changes both
page_for_channeland_invite_oncall_to_channelto return early whenis_private=True, so private incidents trigger no PagerDuty pages and no on-call user invitations at all.The rationale is that private incidents should be fully contained -- only the creator and explicitly added participants should be aware of them.
This also simplifies the code by removing the conditional policy filtering (
policies_to_page/policies_to_invitedicts) and the "Private Incident" title masking, since neither function proceeds past the early return for private incidents.0
Resolves RELENG-829
Agent transcript: https://claudescope.sentry.dev/share/qsIWVQpzXBWCvgFuxekwvsr7zSfwgYS5xraF9KBrBZk