fix(sentry): Prevent info-level mcp shutdown summaries from creating Sentry issues#454
Open
sentry[bot] wants to merge 1 commit into
Open
fix(sentry): Prevent info-level mcp shutdown summaries from creating Sentry issues#454sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
captureMcpShutdownSummaryfunction insrc/utils/sentry.tswould callSentry.captureEvent()for all MCP shutdown summaries, including those with aninfolevel. This led to millions of Sentry issues being created for normal, non-anomalous application shutdowns, causing significant noise and obscuring actual problems.This change modifies
captureMcpShutdownSummaryto return early if the determined shutdownlevelis'info'. This ensures thatSentry.captureEvent()is only called forwarningorerrorlevel shutdowns, effectively stopping the creation of Sentry issues for routine application exits while still capturing genuine problems.Fixes XCODEBUILDMCP-Z