Skip to content

Polish workflow panel surface #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SawyerHood merged 2 commits into from
Aug 26, 2026
Merged

Polish workflow panel surface #2497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca08920
Polish workflow panel surface
SawyerHood Aug 26, 2026
1890b85
Bump plugin SDK for parity type update
SawyerHood Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/domain/src/plugin-sdk-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// PLUGIN_SDK_MAJOR is 0, so the major-only artifact gate cannot distinguish
// 0.x releases and is intentionally vacuous for them until a future 1.0.
// Rebuildable artifacts still rebuild on the exact sdkVersion-differs trigger.
export const PLUGIN_SDK_VERSION = "0.4.22";
export const PLUGIN_SDK_VERSION = "0.4.23";

/** Major of {@link PLUGIN_SDK_VERSION} — the plugin API compatibility number. */
export const PLUGIN_SDK_MAJOR = Number(PLUGIN_SDK_VERSION.split(".", 1)[0]);
2 changes: 1 addition & 1 deletion packages/plugin-api-map/sdk-public-api.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
},
"./provider-bridge/testing": {
"types": "bundled-types/bb-plugin-sdk-provider-bridge-testing.d.ts",
"sha256": "7c97c6976876e450ecc9dab36314a48215aae11054e410f985433cd322f9cde8"
"sha256": "c35f7c70cdde2281a6fc5b51a041ea9281f4c232d6a4d730a823cbd5ef8aa8a9"
},
"./testing": {
"types": "bundled-types/bb-plugin-sdk-testing.d.ts",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@get-bb/plugin-sdk",
"version": "0.4.22",
"version": "0.4.23",
"homepage": "https://github.com/get-bb/bb#readme",
"bugs": {
"url": "https://github.com/get-bb/bb/issues"
Expand Down
5 changes: 5 additions & 0 deletions plugins/workflows/src/app.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,6 +685,11 @@ describe("workflow thread panel", () => {
);

await slot.findByText("Run independent checks before shipping.");
const scrollArea = slot.container.querySelector(
'[data-detail-scroll-area="workflow-panel"]',
);
expect(scrollArea?.className).toContain("p-4");
expect(scrollArea?.parentElement?.className).toContain("bg-border");
// The settled Discover phase starts collapsed; the active phase is open.
expect(slot.queryByText("Inspect implementation")).toBeNull();
expect(slot.getByText("Adversarial review")).toBeTruthy();
Expand Down
14 changes: 8 additions & 6 deletions plugins/workflows/src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,11 +861,13 @@ function WorkflowPreviewLoaded({
function WorkflowRunPanel({ threadId, params }: PluginThreadPanelProps) {
const runId = panelRunId(params);
return (
<div className="h-full min-h-0 flex-1 p-4">
<div className="h-full min-h-0 flex-1 bg-border">
{runId === undefined ? (
<EmptyOrError>
This workflow panel has invalid run parameters.
</EmptyOrError>
<div className="p-4">
<EmptyOrError>
This workflow panel has invalid run parameters.
</EmptyOrError>
</div>
) : (
<WorkflowRunPanelLoaded threadId={threadId} runId={runId} />
)}
Expand Down Expand Up @@ -921,10 +923,10 @@ function WorkflowRunPanelLoaded({
}
};
return (
<div className="flex h-full min-h-0 flex-col bg-background">
<div className="flex h-full min-h-0 flex-col bg-border">
<div
data-detail-scroll-area="workflow-panel"
className="min-h-0 flex-1 overflow-y-auto"
className="min-h-0 flex-1 overflow-y-auto p-4"
>
<div className="flex items-start gap-2">
<div className="min-w-0 flex-1">
Expand Down