Add optional transparent Linux desktop windows - #2493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
Small fix to allow transparency - added as an option. Maybe opinionated but suggest it's a default as can't see it causing any issues.
What was wrong
Electron creates opaque desktop windows by default, so Linux compositors cannot show transparency or blur behind bb even when a custom CSS theme uses translucent colors. This leaves compositor-level effects unavailable after the frameless Linux window option added in #1785. Fixes #1916.
What changed
--transparent-windowstartup flag.transparent: trueandbackgroundColor: "#00000000"window options when requested.--no-window-frame; both remain opt-in and can be combined.BrowserWindowoption coverage.How you verified
pnpm exec turbo run typecheck --filter=@bb/desktoppnpm exec turbo run test --filter=@bb/desktop --force(37 files, 243 tests passed)pnpm exec prettier --check apps/desktop/README.md apps/desktop/src/desktop-window-factory.ts apps/desktop/src/desktop-window-transparency.ts apps/desktop/src/main.ts apps/desktop/test/desktop-window-factory.test.ts apps/desktop/test/desktop-window-transparency.test.tsgit diff --checkFixes #1916