Fix Linux AppImage runtime mount lifecycle - #2491
Merged
Merged
Conversation
Co-authored-by: Salem Sayed <salem.sayed@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
This pull request replaces #1781 because the source branch for that pull request was deleted.
The replacement preserves the original work and gives co-author credit to @salemsayed.
What was wrong
The packaged desktop started the long-lived bb-app bridge through an executable inside the desktop AppImage mount. The bridge and its descendants could continue after that mount disappeared. These processes could then fail with
SIGBUSorBUS_ADRERRerrors.What changed
This change does not alter the host daemon protocol.
How you verified
pnpm exec turbo run typecheck test --filter=@bb/desktopgit diff --check origin/main...HEADReplaces #1781.