fix double-decode and double-encode in byte stuffing codec#6
Open
jktjkt wants to merge 1 commit intogertvdijk:developfrom
Open
fix double-decode and double-encode in byte stuffing codec#6jktjkt wants to merge 1 commit intogertvdijk:developfrom
jktjkt wants to merge 1 commit intogertvdijk:developfrom
Conversation
Calling the replacement function multiple times is wrong because it looks at partially decoded data which are decoded again. We could fix that by using a different order for encode and decode, but I like this implementation much more because it will also flag unrecognized or truncated stuffing sequences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling the replacement function multiple times is wrong because it looks at partially decoded data which are decoded again. We could fix that by using a different order for encode and decode, but I like this implementation much more because it will also flag unrecognized or truncated stuffing sequences.