Skip to content

Fixed types and Added tests#700

Closed
csbobby wants to merge 41 commits intogenerative-computing:mainfrom
csbobby:debug
Closed

Fixed types and Added tests#700
csbobby wants to merge 41 commits intogenerative-computing:mainfrom
csbobby:debug

Conversation

@csbobby
Copy link
Contributor

@csbobby csbobby commented Mar 19, 2026

Requirement PR

Use this template when adding or modifying requirements in mellea/stdlib/requirements/.

Description

  • Link to Issue: Fixes

Implementation Checklist

Base Class

  • Extends appropriate base class:
    • Requirement - standard requirement
    • ALoraRequirement - uses specialized Intrinsic/Adapter for generation-based validation

Validation Logic

  • validation_fn defined (if using Python-based validation)
    • re-usable functionality within the validation_fn should be separated out into mellea/stdlib/tools/
  • validate returns a ValidationResult with
    • a thunk and context if using a backend to generate
    • a specific reason and score when possible

Integration

  • Requirement exported in mellea/stdlib/requirements/__init__.py or, if you are adding a library of requirements, from your sub-module

Testing

  • Tests added to tests/requirements/
  • New code has 100% coverage
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@csbobby csbobby requested a review from a team as a code owner March 19, 2026 06:06
@github-actions
Copy link
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@csbobby csbobby closed this Mar 19, 2026
@csbobby csbobby deleted the debug branch March 19, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant