Skip to content

fix: skip pytest collection of qiskit validation_helpers module (#683)#686

Merged
planetf1 merged 1 commit intogenerative-computing:mainfrom
planetf1:fix/qiskit-helper-skip-collection-683
Mar 18, 2026
Merged

fix: skip pytest collection of qiskit validation_helpers module (#683)#686
planetf1 merged 1 commit intogenerative-computing:mainfrom
planetf1:fix/qiskit-helper-skip-collection-683

Conversation

@planetf1
Copy link
Contributor

@planetf1 planetf1 commented Mar 18, 2026 •
edited
Loading

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

  • Link to Issue:

Fixes #683

validation_helpers.py is a helper module, not a runnable example, but was being collected and executed by pytest. It failed immediately due to a missing optional dependency. Add # pytest: skip consistent with the existing conftest mechanism and with the adjacent qiskit_code_validation.py entry point.

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Mar 18, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@planetf1 planetf1 marked this pull request as ready for review March 18, 2026 09:30
@planetf1 planetf1 requested a review from a team as a code owner March 18, 2026 09:30
@planetf1 planetf1 enabled auto-merge March 18, 2026 09:30
@planetf1
Copy link
Contributor Author

planetf1 commented Mar 18, 2026

This PR is failing CI due to a pre-existing issue unrelated to this change. See #680 for root cause.

The test collection error in test/formatters/granite/test_intrinsics_formatters.py is caused by answer_relevance_classifier/granite-4.0-micro/lora/io.yaml not existing in ibm-granite/granite-lib-rag-r1.0 on Hugging Face Hub. This affects all fresh CI runs (no HF Hub cache) — the tip of main appears green only because its CI runner has a cached copy from a prior run.

This PR's change (adding # pytest: skip to the qiskit helper) is correct and unrelated to the failure.

@planetf1 planetf1 mentioned this pull request Mar 18, 2026
Closed
ajbozarth
ajbozarth approved these changes Mar 18, 2026
View reviewed changes
Copy link
Contributor

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad >.<

AngeloDanducci
AngeloDanducci approved these changes Mar 18, 2026
View reviewed changes
Copy link
Contributor

@AngeloDanducci AngeloDanducci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM unrelated failing check aside.

@planetf1
fix: skip pytest collection of qiskit validation_helpers module (gene…
618324d 
…rative-computing#683)

validation_helpers.py is a helper module, not a runnable example. It was
being collected and executed by pytest, failing immediately with an
ImportError because flake8-qiskit-migration is not a standard dependency.

Add '# pytest: skip' consistent with the existing conftest mechanism and
with the main qiskit_code_validation.py entry point which is already marked.

Fixes generative-computing#683
@planetf1 planetf1 force-pushed the fix/qiskit-helper-skip-collection-683 branch from 29d095b to 618324d Compare March 18, 2026 15:34
@planetf1 planetf1 added this pull request to the merge queue Mar 18, 2026
Merged via the queue into generative-computing:main with commit ab56c85 Mar 18, 2026
6 checks passed
@ajbozarth ajbozarth mentioned this pull request Mar 18, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajbozarth ajbozarth ajbozarth approved these changes

@AngeloDanducci AngeloDanducci AngeloDanducci approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: qiskit validation_helpers.py incorrectly collected as a test — fails with missing flake8-qiskit-migration

3 participants

@planetf1 @ajbozarth @AngeloDanducci