docs: add required models to run tests with ollama backend to the CONTRIBUTING.md doc#674
Conversation
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
ajbozarth
left a comment
ajbozarth
left a comment
There was a problem hiding this comment.
IIUC the tests should just download these automatically (thus why the tests stick to very small models). I can understand wanting to list models that are downloaded, but I don't think the extra commands are worth the doc clutter. I do have some hesitation around listing the models though as well since the list could changes and this would be another place to keep updated.
No strong feeling against this idea though. Many small issues with the actual change below:
CONTRIBUTING.md
Outdated
| ollama pull granite4:micro-h | ||
| ollama pull granite3.2-vision | ||
| ollama pull granite4:micro | ||
| ollama pull qwen2.5vl:7b |
There was a problem hiding this comment.
I would maybe add the list of required models down to the Testing section (maybe right after the quick reference), something like
### Required models
Ollama
- granite4:micro-h
- ...
_Note: ollama models can be obtained by running `ollama pull <model>_
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
code4days
force-pushed
the
re/add-ollama-model-requirements
branch
2 times, most recently
from
2e964b5 to
8a9d5da
Compare
…ests to run Adds a Required models section with a list of required ollama models for non qualitative tests to pass Supports generative-computing#574
code4days
force-pushed
the
re/add-ollama-model-requirements
branch
from
8a9d5da to
9694e16
Compare
|
|
||
| This script handles environment setup, dependency installation, and pre-commit hook installation. | ||
|
|
||
|
|
|
|
||
| ### Verify Installation | ||
|
|
||
| Pull [required models](#required-models) |
There was a problem hiding this comment.
nit: looking at the doc as a whole, I would actually put this link with the ollama prereq. Maybe say something like
- [Ollama](https://ollama.com/download) with [required models](#required-models) (for local testing)3 participants
Misc PR
Type of PR
Description
Adds 'Models Required to Run Tests in test/' section to the
CONTRIBUTING.mddoc with a list of required models for the ollama backend. It also updates the verification steps to include the ollama pull commands.Also raised #673 to address one test case that failed consistently due to a dependency issue.
Testing