Generate impact report in PDF and PNG formats#11523
Open
ptormene wants to merge 192 commits into
Open
Conversation
…kind either 'mosaic_model' or 'country'; add corresponding tests
…tly are not in the engine repo
…e, avoiding to break the pdf layout
…oose the adm_level
…reduce the number of function arguments
…arameters and map data elements
…if they are all zeros)
…g, also look for them in oq-engine before raising an error
…but missing [ci skip]
…alled by the existing get_closest_country
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has been there for months and it's time to finalize it.
Now we are busy with other urgent tasks, but I am opening this PR as a draft, so we can start reviewing the code.
The new feature require some additional python packages and I decided to create a separate requirements file specific for impact (and I did the same for aelo).