RFC: 1026 function overloading - #86
Open
aljazerzen wants to merge 4 commits into
Open
Conversation
aljazerzen
force-pushed
the
function-overloading
branch
from
January 23, 2024 17:08
13fc74d to
49da8ce
Compare
aljazerzen
commented
Jan 23, 2024
|
|
||
| Note that in user-defined functions, it is not allowed to use | ||
| pseudo-types or overload functions that take object types. Overloading | ||
| of functions that take scalar types does not work correctly. This means |
Contributor
Author
There was a problem hiding this comment.
This is what happens with scalars currently:
create scalar type A extending str;
create scalar type B extending A;
create function foo(a: str) -> str using ("matched str");
create function foo(a: A) -> str using ("matched A");
select foo(<str>"hello"); # error: please disambiguate between the two function
# I would say this is incorrect, it should "match str"
select foo(<A>"hello"); # matched A
# correct
select foo(<B>"hello"); # internal server error: function edgedbpub."..." is not unique
# obviously bad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.